Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds email subscription to policy papers and consultations finder #929

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.
+62 −2
Diff settings

Always

Just for now

@@ -165,7 +165,7 @@ def query_builder_class
# "/guidance-and-regulation" => "guidance_and_regulation"
FINDERS_IN_DEVELOPMENT = {
"/policy-papers-and-consultations" => 'policy_and_engagement',
"/statistics" => "statistics"
"/statistics" => "statistics",
}.freeze

def development_env_finder_json
@@ -22,7 +22,24 @@

},
"publishing_request_id":"",
"links":{},
"links":{
"email_alert_signup": [
{
"api_path": "/api/content/policy-papers-and-consultations/email-signup",
"base_path": "/policy-papers-and-consultations/email-signup",
"content_id": "5a4dc517-57cf-4dd6-873f-f1d29f6d540c",
"document_type": "finder_email_signup",
"locale": "en",
"public_updated_at": "2019-03-06T10:22:17Z",
"schema_name": "finder_email_signup",
"title": "Policy papers and consultations",
"withdrawn": false,
"links": {},
"api_url": "https://www.gov.uk/api/content/policy-papers-and-consultations/email-signup",
"web_url": "/policy-papers-and-consultations/email-signup"
}
]
},
"description":"Find policy papers and consultations from government",
"details":{
"document_noun":"result",
@@ -0,0 +1,43 @@
{
"base_path": "/policy-papers-and-consultations/email-signup",
"content_id": "5a4dc517-57cf-4dd6-873f-f1d29f6d540c",
"document_type": "finder_email_signup",
"title": "Policy papers and consultations",
"description": "You'll get an email each time policy papers and consultations are published.",
"details": {
"filter": {
"content_purpose_supergroup": "policy-papers-and-consultations"

This comment has been minimized.

Copy link
@bilbof

bilbof Mar 8, 2019

Contributor

This needs to be: policy_and_engagement.

},
"email_filter_by": null,
"email_filter_name": null,
"subscription_list_title_prefix": "Policy papers and consultations",
"email_filter_facets": [
{
"facet_id": "people",
"facet_name": "people"
},
{
"facet_id": "organisations",
"facet_name": "organisations"
},
{
"facet_id": "document_type",

This comment has been minimized.

Copy link
@bilbof

bilbof Mar 8, 2019

Contributor

This'll need to be content_store_document_type, and it should support option_lookup behaviour like the finder (otherwise we'll pass content_store_document_type=policy_papers to email-alert-api when we should be passing content_store_document_type=[impact_assessment,case_study,policy_paper]).

"facet_name": "document types"
},
{
"facet_id": "world_locations",
"facet_name": "world locations"
},
{
"facet_id": "level_one_taxon",
"filter_key": "all_part_of_taxonomy_tree",
"facet_name": "topics"
},
{
"facet_id": "level_two_taxon",
"filter_key": "all_part_of_taxonomy_tree",
"facet_name": "topics"
}
]
}
}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.