Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align form builder home screen with the prototype #45

Merged
merged 11 commits into from
May 26, 2022
Merged

Conversation

DavidBiddle
Copy link
Contributor

@DavidBiddle DavidBiddle commented May 26, 2022

What problem does the pull request solve?

Closes #42

I've added a basic overview page so that I have something to point to - currently I'm using the show view for this and the edit view for what will probably eventually be the edit title page, I'm sure we'll want to change this eventually but i think it works for now.

I'm not entirely convinced the cypress tests I've written are adding much at the moment - I'm open to suggestions on better things to test here, but these will at least be enough to work with in our CI pipeline (see #46).

  • Update form home screen create button to match the prototype
  • Update form list display to match the prototype
    • Note: In Dev we can keep the link to the runner for now as a link underneath the form name or something similar
  • Edit links take you to the form overview screen (depends on Create initial form overview screen #43 )
  • Create request and frontend specs for this

Checklist

  • I've used the pull request template
  • I've linked this PR to the relevant issue (if mission work)
  • I've written unit tests for these changes (if code change)
  • [n/a] I've updated the documentation in (If any documentation requires updating)

@DavidBiddle DavidBiddle requested a review from a team as a code owner May 26, 2022 15:08
@DavidBiddle DavidBiddle changed the title Forms home page Align form builder home screen with the prototype May 26, 2022
Copy link
Contributor

@danielburnley danielburnley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the line i commented on is intentionally left in, but seems good! Feel free to delete that line and merge if need be

It might be worth creating an issue for running the cypress tests in the pipeline and we can grab it at some point soon (I'm happy to try if you're unsure how to do it), but it can be separate to this PR

app/controllers/forms_controller.rb Outdated Show resolved Hide resolved
@DavidBiddle DavidBiddle merged commit 730f602 into main May 26, 2022
@DavidBiddle DavidBiddle deleted the forms-home-page branch May 26, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align form builder home screen with the prototype
2 participants