Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete guides #1223

Merged
merged 3 commits into from May 12, 2017
Merged

Delete guides #1223

merged 3 commits into from May 12, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 9, 2017

https://trello.com/c/sHoT4xLa/344-1-final-stage-remove-guides-from-alphagov-frontend

Guides are now rendered by government-frontend, remove:

  • views, tests, controllers
  • parts presenter and tests
  • references to guides in travel advice
  • unused translations for guides, travel advice and answers
fofr added 3 commits May 8, 2017
* Guides got moved to government-frontend:
alphagov/government-frontend#338
* The travel advice index is not a guide
* Old travel advice pages were like guides
* Remove concept of guide from frontend
Travel advice is rendered by government-frontend. These strings aren’t
used in the index page rendered by frontend.
@nickcolley
Copy link
Contributor

@nickcolley nickcolley commented May 9, 2017

You can use @fields.application:frontend AND controller:guide with https://kibana.publishing.service.gov.uk

@fofr fofr changed the title [Do not merge] Delete guides Delete guides May 11, 2017
Copy link
Contributor

@mcgoooo mcgoooo left a comment

@fofr fofr merged commit fbc995d into master May 12, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the delete-guides branch May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.