Add gifs to track availability of JavaScript #452

Merged
merged 7 commits into from Oct 8, 2013

Conversation

Projects
None yet
5 participants
@tombye
Contributor

tombye commented Oct 1, 2013

Add code to the homepage to track availability of JavaScript among our users.

To be removed one week from merge.

Dependant on this config change to stop the gifs having the default expires headers:

https://github.gds/gds/puppet/pull/978

Do not merge until the above is part of master.

@ghost ghost assigned bradwright Oct 1, 2013

@bradwright

This comment has been minimized.

Show comment
Hide comment
@bradwright

bradwright Oct 1, 2013

Contributor

Can we talk about this before we merge? I'd like to better understand the context of all this (Pete explained it to me, but I'd like to discuss it more).

Contributor

bradwright commented Oct 1, 2013

Can we talk about this before we merge? I'd like to better understand the context of all this (Pete explained it to me, but I'd like to discuss it more).

@bradwright

This comment has been minimized.

Show comment
Hide comment
@bradwright

bradwright Oct 2, 2013

Contributor

I've updated this to make sure we use the Rails asset helpers for the JS-only GIF as well.

Contributor

bradwright commented Oct 2, 2013

I've updated this to make sure we use the Rails asset helpers for the JS-only GIF as well.

@mnowster

This comment has been minimized.

Show comment
Hide comment
@mnowster

mnowster Oct 3, 2013

Contributor

@tombye @bradleywright this pull request is currently blocked. While the referenced puppet PR was merged into master, there has not yet been, nor will be this week(as I understand it) a puppet deploy to production. Speak to Ops for further details.

Contributor

mnowster commented Oct 3, 2013

@tombye @bradleywright this pull request is currently blocked. While the referenced puppet PR was merged into master, there has not yet been, nor will be this week(as I understand it) a puppet deploy to production. Speak to Ops for further details.

@mnowster

This comment has been minimized.

Show comment
Hide comment
@mnowster

mnowster Oct 3, 2013

Contributor

Once the puppet deploy has gone out, I am happy for this to get merged.

Contributor

mnowster commented Oct 3, 2013

Once the puppet deploy has gone out, I am happy for this to get merged.

Shotclog added a commit that referenced this pull request Oct 8, 2013

Merge pull request #452 from alphagov/add-non-js-tracking
Add gifs to track availability of JavaScript

@Shotclog Shotclog merged commit 9d2bca4 into master Oct 8, 2013

1 check passed

default The Travis CI build passed
Details

@Shotclog Shotclog deleted the add-non-js-tracking branch Oct 8, 2013

@jabley

This comment has been minimized.

Show comment
Hide comment
@jabley

jabley Jan 21, 2016

Contributor

Did we consider using 204 No Content rather than actually sending images? (appreciate this was ages ago and not all people involved are still at GDS)

Contributor

jabley commented Jan 21, 2016

Did we consider using 204 No Content rather than actually sending images? (appreciate this was ages ago and not all people involved are still at GDS)

@bradwright

This comment has been minimized.

Show comment
Hide comment
@bradwright

bradwright Jan 21, 2016

Contributor

@jabley we didn't.

Contributor

bradwright commented Jan 21, 2016

@jabley we didn't.

fofr added a commit that referenced this pull request Apr 19, 2016

malcolmbaig added a commit that referenced this pull request Feb 6, 2017

Revert removal of Javascript tracking images
Revert "Revert "Merge pull request #452 from alphagov/add-non-js-tracking""
This reverts commit 2780a53.

We're re-running this experiment, so let's add back these images and
their tags.

carolinegreen added a commit that referenced this pull request Mar 17, 2017

Revert removal of Javascript tracking images
Revert "Revert "Merge pull request #452 from alphagov/add-non-js-tracking""
This reverts commit 2780a53.

We're re-running this experiment, so let's add back these images and
their tags.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment