Remove focus on <main> element #580

Merged
merged 1 commit into from May 7, 2014

Conversation

Projects
None yet
3 participants
@tommyp
Contributor

tommyp commented May 2, 2014

Having a negative tab index allows the user to focus on the main element, which adds an outline from a user agent stylesheet. This was added in cd20d6e but the 'Skip to content' links behaviour is unchanged in my commit.

Screenshot from the current state. This commit removes blue line from this screenshot:
screen shot 2014-05-02 at 12 15 43

Remove focus on <main> element
Having a negative tab index allows the user to focus on the main element,
which adds an outline from a user agent stylesheet. This was added in
cd20d6e
but the 'Skip to content' links behaviour is unchanged in this commit.
@bradwright

This comment has been minimized.

Show comment
Hide comment
@bradwright

bradwright May 3, 2014

Contributor

@workwithgreat ?

Contributor

bradwright commented May 3, 2014

@workwithgreat ?

@partiallyblind

This comment has been minimized.

Show comment
Hide comment
@partiallyblind

partiallyblind May 7, 2014

Contributor

Sorry @bradleywright, just spotted this.

Totally fine to remove the tabindex.

Contributor

partiallyblind commented May 7, 2014

Sorry @bradleywright, just spotted this.

Totally fine to remove the tabindex.

bradwright added a commit that referenced this pull request May 7, 2014

@bradwright bradwright merged commit 43fcffe into master May 7, 2014

1 check passed

default "Build #142 succeeded on Jenkins"
Details

@bradwright bradwright deleted the remove-focus-on-main-element branch May 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment