New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-hidden to horizontal rules #823

Merged
merged 1 commit into from Jun 17, 2015

Conversation

Projects
None yet
4 participants
@edds
Contributor

edds commented Jun 17, 2015

The homepage is split by sections anyway and doesn't need extra
splitting. In a screen reader it announces 'group services and
information, horizontal rule, group department and policy, horizontal
rule...". The horizontal rules are extra noise which are just
distracting.

Add aria-hidden to horizontal rules
The homepage is split by sections anyway and doesn't need extra
splitting. In a screen reader it announces 'group services and
information, horizontal rule, group department and policy, horizontal
rule...". The horizontal rules are extra noise which are just
distracting.

alicebartlett added a commit that referenced this pull request Jun 17, 2015

Merge pull request #823 from alphagov/hide-hrs
Add aria-hidden to horizontal rules

@alicebartlett alicebartlett merged commit d38e060 into master Jun 17, 2015

1 check passed

default "Build #787 succeeded on Jenkins"
Details

@alicebartlett alicebartlett deleted the hide-hrs branch Jun 17, 2015

@alextea

This comment has been minimized.

Show comment
Hide comment
@alextea

alextea Jun 17, 2015

Member

If that's the case is there a reason why the rules aren't applied as styling to the sections?

Member

alextea commented Jun 17, 2015

If that's the case is there a reason why the rules aren't applied as styling to the sections?

@edds

This comment has been minimized.

Show comment
Hide comment
@edds

edds Jun 17, 2015

Contributor

@alextea the problem is that there are no elements to apply the styling to. This is due to us using negative margins on wrapping elements so that we can float inner elements with margins on them for gutters. Though this might be different with the new grid mixins. So for the moment we need to use a 'dummy' element and the HR at least makes sense as something to add a keyline onto the page.

Contributor

edds commented Jun 17, 2015

@alextea the problem is that there are no elements to apply the styling to. This is due to us using negative margins on wrapping elements so that we can float inner elements with margins on them for gutters. Though this might be different with the new grid mixins. So for the moment we need to use a 'dummy' element and the HR at least makes sense as something to add a keyline onto the page.

@tombye

This comment has been minimized.

Show comment
Hide comment
@tombye

tombye Jun 18, 2015

Contributor

👍 (sorry for the lateness.)

As a rule (no pun intended) I'd say the value of hr's is their ability to provide a break in text when that text isn't already divided up into other groupings. It's like in print I guess, where they're used when there is a break between types of copy not indicated by their presentation (the containing chapters or pages).

I mention this as a note for future use, that there may be a need for announcing them in some of our longer-form documents. As for here, totally agree with the intent.

Contributor

tombye commented Jun 18, 2015

👍 (sorry for the lateness.)

As a rule (no pun intended) I'd say the value of hr's is their ability to provide a break in text when that text isn't already divided up into other groupings. It's like in print I guess, where they're used when there is a break between types of copy not indicated by their presentation (the containing chapters or pages).

I mention this as a note for future use, that there may be a need for announcing them in some of our longer-form documents. As for here, totally agree with the intent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment