Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop non-js tracking on the homepage #944

Merged
merged 1 commit into from Apr 21, 2016
Merged

Stop non-js tracking on the homepage #944

merged 1 commit into from Apr 21, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Apr 19, 2016

This code was meant to be temporary, #452:

To be removed one week from merge.

It's been running 2.5 years. We might also want to revert https://github.gds/gds/puppet/pull/978

Revert "Merge pull request #452 from alphagov/add-non-js-tracking". This reverts commit 9d2bca4, reversing changes made to bfd5f6b.

cc @tombye

This reverts commit 9d2bca4, reversing
changes made to bfd5f6b.
fofr added a commit to alphagov/govuk-puppet that referenced this issue Apr 19, 2016
The code to remove non-js tracking is being removed in
alphagov/frontend#944

We should also remove the parts added here, in:
https://github.gds/gds/puppet/pull/978
003254a
707ccba7367c1adf
e10bc99
cc6a0129b846582e
@fofr
Copy link
Contributor Author

@fofr fofr commented Apr 19, 2016

WIP branch to remove on puppet too, it'd be good to get a sanity check on that:
https://github.com/alphagov/govuk-puppet/compare/revert-non-js-tracking

@boffbowsh boffbowsh merged commit 9c804a3 into master Apr 21, 2016
1 check passed
@boffbowsh
Copy link
Contributor

@boffbowsh boffbowsh commented Apr 21, 2016

And the puppet change looks good too, so raise a PR for that when you're ready 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants