Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide EU referendum banner after 4pm 26 May (accounting for cache time) #952

Merged
merged 1 commit into from May 13, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 13, 2016

  • Add basic home page integration test
  • Takes into account 15 min cache time to coincide with the 4pm cut-off for the global banner
* Add basic home page integration test
* Coincide with changes to the global banner
@boffbowsh
Copy link
Contributor

@boffbowsh boffbowsh commented May 13, 2016

Worth noting somewhere that this is taking into account cache time so that the banner won't show after 4pm.

@boffbowsh
Copy link
Contributor

@boffbowsh boffbowsh commented May 13, 2016

But yes, 👍

@fofr fofr changed the title Hide EU referendum banner after 3:45pm 26 May Hide EU referendum banner after 4pm 26 May (accounting for cache time) May 13, 2016
end

should "render an EU referendum banner before 3:45pm May 26" do
travel_to Time.zone.parse('May 26 2016 15:44:00 BST') do

This comment has been minimized.

@tvararu

tvararu May 13, 2016
Contributor

travel_to

Neat.

@tvararu
Copy link
Contributor

@tvararu tvararu commented May 13, 2016

👍

@tvararu tvararu merged commit e14423c into master May 13, 2016
1 check passed
1 check passed
default "Build #1217 succeeded on Jenkins"
Details
@tvararu tvararu deleted the hide-eu-banner-from-26-may branch May 13, 2016
fofr added a commit that referenced this pull request May 13, 2016
Reverts PRs #936 #952 #938

We don’t intend to use this again soon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.