Permit bearer_token field to be JSON #1078
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the bearer_token option for the JsonClient to be a JSON with the structure
'{"value": <string>}'
.Trello: https://trello.com/c/6Uaayg1l/545-use-a-single-rotation-lambda-instead-of-duplicating-them-per-secret
Motivation
We would like to store additional data with the secret body, to enable rotation of the bearer token with configuration for the rotation provided in the secret body.
E.g. the secret body may look like this:
The
value
field would contain the bearer token string. The remaining fields would enable rotation by a Lambda.This should not have an impact on the existing platform. I expect secrets stored in
govuk-secrets
to remain unchanged. This will only impact secrets stored in AWS SecretsManager for the new ECS-hosted platform.