Permalink
Browse files

Review of Google-Auth Bridge

- Adding simplecov to rspec
- Changing Author & E-Mail
- Simplification

author: @robyoung
author: @pbadenski
author: @sembirayael
author: @jthoenes
  • Loading branch information...
1 parent 7da527c commit 9c50a0ba4c69fd4f3394bbc040a56d399531eb73 @jthoenes jthoenes committed Aug 29, 2012
Showing with 8 additions and 6 deletions.
  1. +1 −0 .gitignore
  2. +3 −2 google_auth_bridge.gemspec
  3. +1 −4 lib/google_auth_bridge.rb
  4. +3 −0 spec/google_auth_bridge_spec.rb
View
@@ -3,3 +3,4 @@ Gemfile.lock
spec/reports
.bundle
*.gem
+coverage
@@ -2,8 +2,8 @@
require File.expand_path('../lib/google_auth_bridge/version', __FILE__)
Gem::Specification.new do |gem|
- gem.authors = %w(ssatish)
- gem.email = %w(seema.satish@digital.cabinet-office.gov.uk)
+ gem.authors = ["GOV.UK Dev"]
+ gem.email = %w(govuk-dev@digital.cabinet-office.gov.uk)
gem.description = "bridge for supporting multiple google authentication libraries"
gem.summary = "bridge for supporting multiple google authentication libraries"
gem.homepage = "https://github.com/alphagov/google-auth-bridge"
@@ -21,6 +21,7 @@ Gem::Specification.new do |gem|
gem.add_development_dependency("rake")
gem.add_development_dependency("rspec")
gem.add_development_dependency("ci_reporter")
+ gem.add_development_dependency("simplecov")
gem.add_development_dependency("gem_publisher", "~> 1.1.1")
end
@@ -40,10 +40,7 @@ def load_token_from_file
begin
token_data = YAML.load_file(@token_file)
- token = token_data[:refresh_token]
-
- raise InvalidFileFormatError.new(@token_file) unless token
- token
+ token_data[:refresh_token] or raise
rescue
raise InvalidFileFormatError.new(@token_file)
end
@@ -1,3 +1,6 @@
+require "simplecov"
+SimpleCov.start
+
require_relative "../lib/google_auth_bridge"
require "tempfile"

0 comments on commit 9c50a0b

Please sign in to comment.