Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
This is an all the basics PR, it doesn't include the following features:
Tests also depend on alphagov/govuk-content-schemas#250 (hence the test fails)
I'm picking up this work from @fofr while he's away, it's already 95% there.
After the changes in the schema/examples fractions now Just Work™, as the SCSS already existed in the Govspeak Component. Though there isn't a component fixture for fractions, so i'll add one and double check print behaves as we expect. (Edit, done: alphagov/static#747)
I'm happy with leaving org-logos and the fixed contents link to follow up PRs.
I want to have a look at the integration testing, as it's only covering one of the schema examples and I want to make sure we're not missing any cases. After that I think this is
* Port directly from Whitehall * Don't port white external links mixin, contents lists in HTML pubs can't contain external links. https://github.com/alphagov/whitehall/blob/590fee63149416d4167b1151a684e 50cd2b162ee/app/assets/stylesheets/frontend/styleguide/_typography.scss# L126
The HTML publication title is similar but not the same. Avoid brittle overriding of styles and component modes by porting the markup and styles for the relatively simple pattern. * Port responsive margin mixins from static, these, if deemed correct and easily re-usable, can eventually be moved to front-end toolkit.
Decided against adding the additional integration tests for other content examples - they vary that much and where they do tends to be inside markup blocks that are rendered as is, which we're less concerned about testing in this app.
When we add departmental logo support that would be probably deserve an interrogation test for that example.