Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add history notices to detailed guides #137

Merged
merged 2 commits into from Apr 26, 2016
Merged

Add history notices to detailed guides #137

merged 2 commits into from Apr 26, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Apr 25, 2016

Depends on alphagov/govuk-content-schemas#290 for passing tests.

  • Create a mixin for history notice styles
  • Create a partial for history notices
  • Create a Political module for formats that can be political
  • Add mixin, partial and module to detailed guides so that a blue “history mode” banner displays for political content published under a previous government.

Part of:
https://trello.com/c/74ymVfIw/384-6-detailed-guides-migration-front-end-work-for-history-mode-political-status-and-government-small

Before

screen shot 2016-04-25 at 19 23 31

## After

screen shot 2016-04-25 at 19 21 32

* Create a mixin for history notice styles
* Create a partial for history notices
* Create a `Political` module for formats that can be political
* Add mixin, partial and module to detailed guides so that a blue
“history mode” banner displays for political content published under a
previous government.
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-137 Apr 25, 2016 Inactive
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-137 Apr 25, 2016 Inactive
First published, updated and the see all updates link are now part of
the component. We can replace the “other” block.

This also fixes a bug where a “last updated” field would show even if
there were no updates.
@tvararu
Copy link
Contributor

@tvararu tvararu commented Apr 26, 2016

👍

@fofr
Copy link
Contributor Author

@fofr fofr commented Apr 26, 2016

Tests now passing after alphagov/govuk-content-schemas#290 merged

@tvararu tvararu merged commit 323156e into master Apr 26, 2016
1 check passed
@tvararu tvararu deleted the history-notice branch Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants