Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum viable publication rendering #139

Merged
merged 6 commits into from May 6, 2016
Merged

Add minimum viable publication rendering #139

merged 6 commits into from May 6, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 4, 2016

Render the following example accurately:
https://www.gov.uk/government/publications/d17-9ly-veolia-es-uk-limited-environmental-permit-issued

Built in conjunction with:
alphagov/govuk-content-schemas#298
(tests will fail until that is merged)

Intentionally, but temporarily, omits from this example:

  • Format subtype
  • Excluded nations

Further features and examples required for:

  • History notice
  • Withdrawn notice
  • Ministers, topical events, related statistical data sets and other links

publication-format-preview

Part of:
https://trello.com/c/v85kPiKN/366-9-publications-migration-mvp-content-schema-examples-and-front-end-work-medium

fofr added 3 commits May 4, 2016
* Publications are political, linkable, updatable and withdraw-able.
* The body isn’t the “main content”, use a `details` method to pull it
in – this might later conflict with a generic details method
* Pull translations for “Documents” from Whitehall
* No corresponding translation for “Details”
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-139 May 4, 2016 Inactive
* Publications can be withdrawn
* Add test to check that `[Withdrawn]` is added to the page title
which could be easily missed.
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-139 May 6, 2016 Inactive
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-139 May 6, 2016 Inactive
fofr added 2 commits May 6, 2016
Case studies uses `supporting_organisations` and `related_policies`.
Since case studies was built, these names have been standardised to
`policies` and `organisations`, which the publication format will use.

We need to migrate case_studies away from one to the other, for now the
frontend should support both.
Use the political example to run tests
@@ -1,10 +1,17 @@
module Linkable
def from
links("lead_organisations") + links("supporting_organisations") + links("worldwide_organisations")
links("lead_organisations") +
Copy link
Contributor

@boffbowsh boffbowsh May 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to run all this through uniq, as some orgs or policies may appear in more than one of these. Same for part_of

@boffbowsh boffbowsh merged commit 4708c6a into master May 6, 2016
1 check passed
@boffbowsh boffbowsh deleted the publications branch May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants