Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add share buttons to consultations #207

Merged
merged 5 commits into from Dec 19, 2016
Merged

Add share buttons to consultations #207

merged 5 commits into from Dec 19, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Dec 16, 2016

  • Port social media icons from Whitehall, remove unused icons and PNGCrush
  • Simplify markup and CSS for social icons
  • Look and behaviour matches Whitehall
    • Except: Use link colours for share buttons
  • Add javascript tracking of share buttons
  • Fix bug with offset-one-third bug on thin devices

(This is the first JS added to government-frontend. I'd like to include jasmine-rails for JS tests but I had problems running versions 12+ against PhantomJS 1.9.7 on our VM. I will try and fix in a separate PR) Edit: #208

https://trello.com/c/MaZ7t0zi/521-add-share-buttons-to-consultations-on-government-frontend

Whitehall

screen shot 2016-12-16 at 16 29 08

This PR

screen shot 2016-12-16 at 16 28 29

screen shot 2016-12-16 at 16 29 49

fofr added 3 commits Dec 16, 2016
* Port social media icons from Whitehall, remove unused icons and
PNGCrush
* Simplify markup and CSS for social icons
* Look and behaviour matches Whitehall
Save 4% of bytes:

TOTAL was: 11.503kb now: 11.038kb saving: .465kb (4.00%) quality: 100%
Show the button in purple when it matches the visited state. With a
purple link and a blue button it looks like a mistake.

Also use active and hover colours to match full link behaviour.
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-207 Dec 16, 2016 Inactive
Copy link
Contributor

@tvararu tvararu left a comment

Nice one. 👍

@@ -0,0 +1,26 @@
window.GOVUK.Modules = window.GOVUK.Modules || {};

This comment has been minimized.

@tvararu

tvararu Dec 19, 2016
Contributor

This file uses a mix of semicolons and no semicolons but I don't mind it.

This comment has been minimized.

@fofr

fofr Dec 19, 2016
Author Contributor

Updated to match JS Standard style.

fofr added 2 commits Dec 16, 2016
* Tracking ported from Whitehall
* Set up and include first JS in government-frontend
On mobile devices containers using this class would still be shifted
right by a few 100 pixels.
@Rosa-Fox
Copy link
Contributor

@Rosa-Fox Rosa-Fox commented Dec 19, 2016

Looks good to @bevanloon and I.

screen shot 2016-12-19 at 15 51 05

@Rosa-Fox Rosa-Fox merged commit 8f1d0e8 into master Dec 19, 2016
@fofr fofr deleted the share-consultations branch Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.