Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jasmine-rails for javascript testing #208

Merged
merged 3 commits into from Dec 20, 2016
Merged

Add jasmine-rails for javascript testing #208

merged 3 commits into from Dec 20, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Dec 19, 2016

Adding javascript in #207, we need to be able to test it.
Using jasmine-rails to stay consistent with static, finder-frontend and manuals-frontend.

  • Add jasmine-rails
  • Add jasmine rails route for running tests in browser
  • Include dummy spec to prove tests run
  • Run javascript tests by default
  • Use phantomjs provided by path rather than gem

Similar to alphagov/finder-frontend#7

@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-208 Dec 19, 2016 Inactive
* Add jasmine-rails
* Add jasmine rails route for running tests in browser
* Include dummy spec to prove tests run
* Run javascript tests by default
* Use phantomjs provided by path rather than gem

Similar to alphagov/finder-frontend#7
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-208 Dec 19, 2016 Inactive
The global GOVUK object is not available when running JS in the test
environment without JS provided by static.
@fofr fofr force-pushed the add-jasmine branch from 78d7789 to 3358006 Dec 19, 2016
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-208 Dec 19, 2016 Inactive
* Test track-share-button-clicks module
* Lint using JS Standard (as per
alphagov/govuk_frontend_toolkit#334)
* Include jQuery as a spec helper
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-208 Dec 20, 2016 Inactive
@tvararu tvararu merged commit 591807f into master Dec 20, 2016
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@tvararu tvararu deleted the add-jasmine branch Dec 20, 2016
@tvararu
Copy link
Contributor

@tvararu tvararu commented Dec 20, 2016

Nice one. 👏

@tvararu
Copy link
Contributor

@tvararu tvararu commented Dec 21, 2016

This PR is a follow-up: #213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.