Run tests against jQuery 1.12.4 #211
Merged
Conversation
See alphagov/static#869 https://blog.jquery.com/2016/01/08/jquery-2-2-and-1-12-released/ https://blog.jquery.com/2016/02/22/jquery-1-12-1-and-2-2-1-released/ https://blog.jquery.com/2016/03/17/jquery-1-12-2-and-2-2-2-released/ https://blog.jquery.com/2016/04/05/jquery-1-12-3-and-2-2-3-released/ https://blog.jquery.com/2016/05/20/jquery-1-12-4-and-2-2-4-released/
I've switched this to use the non-minified version. This matches other apps and would make debugging failing tests easier. |
This looks good to me, I've also tested a consultation page where we're tracking social media links and that's working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Part of alphagov/static#869
https://blog.jquery.com/2016/01/08/jquery-2-2-and-1-12-released/
https://blog.jquery.com/2016/02/22/jquery-1-12-1-and-2-2-1-released/
https://blog.jquery.com/2016/03/17/jquery-1-12-2-and-2-2-2-released/
https://blog.jquery.com/2016/04/05/jquery-1-12-3-and-2-2-3-released/
https://blog.jquery.com/2016/05/20/jquery-1-12-4-and-2-2-4-released/