Allow speeches to be translated #218

Merged
merged 2 commits into from Jan 5, 2017

Projects

None yet

3 participants

@fofr
Member
fofr commented Jan 3, 2017 edited
  • Add language switcher
  • Switch to using the new Metadata module which adds right-to-left support
  • Add right to left styling for speeches (matches case-studies approach)

Tests depend on alphagov/govuk-content-schemas#472

Note that in both old and new the helper text for the format (eg Transcript of the speech, exactly as it was delivered) is not translated. We ought to fix this when migrating the format.

Old New
translated-speech-old translated-speech-new

Part of https://trello.com/c/TWsLTRzc/547-speech-migration-1-mvp-content-schema-examples-and-front-end-work

@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-218 Jan 3, 2017 Inactive
@gpeng
gpeng approved these changes Jan 5, 2017 View changes
fofr added some commits Jan 3, 2017
@fofr fofr Switch speeches to metadata module 4ca1e83
@fofr fofr Allow speeches to be translated
* Metadata module added in right-to-left support
* Add right to left styling for speeches (matches case-studies approach)
579fdef
@fofr
Member
fofr commented Jan 5, 2017

Rebased against master and fixed merge conflicts regarding Title component refactor.

@gpeng gpeng merged commit f3700d9 into master Jan 5, 2017

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details
@gpeng gpeng deleted the refactor-speeches branch Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment