Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow speeches to be translated #218

Merged
merged 2 commits into from Jan 5, 2017
Merged

Allow speeches to be translated #218

merged 2 commits into from Jan 5, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jan 3, 2017

  • Add language switcher
  • Switch to using the new Metadata module which adds right-to-left support
  • Add right to left styling for speeches (matches case-studies approach)

Tests depend on alphagov/govuk-content-schemas#472

Note that in both old and new the helper text for the format (eg Transcript of the speech, exactly as it was delivered) is not translated. We ought to fix this when migrating the format.

Old New
translated-speech-old translated-speech-new

Part of https://trello.com/c/TWsLTRzc/547-speech-migration-1-mvp-content-schema-examples-and-front-end-work

@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-218 Jan 3, 2017 Inactive
@gpeng
gpeng approved these changes Jan 5, 2017
fofr added 2 commits Jan 3, 2017
* Metadata module added in right-to-left support
* Add right to left styling for speeches (matches case-studies approach)
@fofr
Copy link
Contributor Author

@fofr fofr commented Jan 5, 2017

Rebased against master and fixed merge conflicts regarding Title component refactor.

@gpeng gpeng merged commit f3700d9 into master Jan 5, 2017
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@gpeng gpeng deleted the refactor-speeches branch Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.