Don't show empty contents lists on HTML publications #224

Merged
merged 1 commit into from Jan 5, 2017

Projects

None yet

3 participants

@fofr
Member
fofr commented Jan 4, 2017

Not all HTML publications have a list of headings. When there are none, don’t include the empty list or its associated heading.

@gpeng Can you confirm how we publish headings for HTML publications without any headings? Is it passed through as an empty ordered list as in the example? This exists as a bug on live, and I've presumed the logic hasn't been fixed: https://www.gov.uk/government/publications/canada-united-kingdom-joint-declaration/canada-united-kingdom-joint-declaration

Before

screen shot 2017-01-04 at 17 00 51

After

screen shot 2017-01-04 at 17 00 16

@fofr fofr Don't show empty contents lists
Not all HTML publications have a list of headings. When there are none,
don’t include the empty list or its associated heading.
8ba88ed
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-224 Jan 4, 2017 Inactive
@fofr fofr changed the title from Don't show empty contents lists to Don't show empty contents lists on HTML publications Jan 4, 2017
@gpeng
gpeng approved these changes Jan 5, 2017 View changes
@fofr
Member
fofr commented Jan 5, 2017

We shouldn't send an empty list for headings when there are none, but for now this will fix it for users.

@fofr fofr merged commit c511574 into master Jan 5, 2017

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details
@fofr fofr deleted the hide-empty-contents branch Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment