Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip trailing colons from contents list #225

Merged
merged 1 commit into from Jan 10, 2017
Merged

Strip trailing colons from contents list #225

merged 1 commit into from Jan 10, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jan 5, 2017

When extracting headings from content, discard trailing colons. The colon may make sense in the body of content, but it’s incorrect in a list of contents.

Before

screen shot 2017-01-05 at 14 17 21

After

screen shot 2017-01-05 at 14 14 02

When extracting headings from content, discard trailing colons. The
colon may make sense in the body of content, but it’s incorrect in a
list of contents.
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-225 Jan 5, 2017 Inactive
@gpeng
gpeng approved these changes Jan 10, 2017
@fofr fofr merged commit e24743b into master Jan 10, 2017
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@fofr fofr deleted the no-colons-in-contents branch Jan 10, 2017
fofr added a commit to alphagov/specialist-frontend that referenced this pull request Feb 7, 2017
* Matches government-frontend:
alphagov/government-frontend#225
* The colon may make sense in the body of content, but it’s incorrect
in a list of contents
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.