Move meta description and page class to base layout #230
Conversation
* Simplify each of the formats * Protect against formats forgetting to include
Always set to the singular dasherized format
All formats set the page_class consistently, we can move this directly into the base layout and DRY up the individual format templates. This reduces the risk that a format is added in a way that behaves differently.
fofr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
When adding formats it's easy to forget to set the meta description to the content item’s description. This is a sensible default. Description isn't always present (eg html publications), in those cases omit the meta tag.
Almost all formats set the page class consistently to the dasherized version of the format name. Make those that were slightly different consistent and switch responsibility to the base layout, DRYing up the format templates. This reduces the risk of a format being accidentally added with a different page_class behaviour.