Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IE specific stylesheets #234

Closed
wants to merge 1 commit into from
Closed

Remove IE specific stylesheets #234

wants to merge 1 commit into from

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jan 20, 2017

There are no IE specific styles in this application.

The govuk_frontend_toolkit defines some IE helpers here: https://github.com/alphagov/govuk_frontend_toolkit/blob/2011e77436fccd31f32a0a975a2bf4cc3b961495/stylesheets/_conditionals.scss#L67-L81

These rely on the IE6-8 specific stylesheets. We've ported almost all the formats now and we haven't had to override styles for these older browsers.

There are no IE specific styles in this application.
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-234 Jan 20, 2017 Inactive
@fofr fofr changed the title [Do not merge] Remove IE specific stylesheets Remove IE specific stylesheets Jan 20, 2017
@gpeng
gpeng approved these changes Jan 23, 2017
@fofr fofr closed this Jan 24, 2017
@fofr
Copy link
Contributor Author

@fofr fofr commented Jan 24, 2017

These stylesheets are needed to correctly interpret media queries.

@nickcolley nickcolley deleted the remove-ie-stylesheets branch Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.