Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render corporate information page format #241

Merged
merged 10 commits into from Feb 6, 2017
Merged

Render corporate information page format #241

merged 10 commits into from Feb 6, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jan 30, 2017

Goes with alphagov/govuk-content-schemas#501 (tests will fail until this is merged and deployed)
Part of https://trello.com/c/8ySlDVSs/578-corp-info-migration-1-mvp-content-schema-examples-and-front-end-work

Design notes

  • Design updated to match other formats, with description above two columns of content
  • Body content switched to use component, makes copy look consistent
  • Replace "homepage" link with a breadcrumb
  • Bigger logos and custom org logo images coming soon

Screenshots

Feature Old New
Complaints cip_complaints_old cip_complaints_new
Translated with custom logo cip_custom_logo_translated_old cip_custom_logo_translated_new
About pages cip_about_old cip_about_new
fofr added 10 commits Jan 26, 2017
Run `rails generate format corporate_information_page`
* Pick up latest organisation colours
* 3 breaking changes have no effect on this repo:
https://github.com/alphagov/govuk_frontend_toolkit/blob/master/CHANGELOG
.md
Allows all links on a page to be branded with the web safe text colour
for that organisation. Colours are defined in govuk_frontend_toolkit
and are assured to have good contrast against white.
* Create an organisation branding module
* Move organisation_brand hack from HTML pub presenter, it will need to
be used elsewhere
* Use the `organisation_logo` method to render the component, cleaning
up the view
* Wrap content in a brand class for adding link colours
* Include an organisation logo above header, should be larger but
component doesn’t support yet
* Show title, description and body with generated contents alongside
* Simplify HTML pub tests to check that the module is included
* Include tests for module
* Test that corp info pages include the module
* Normalize white space in govspeak test
* Add organisation logo test helper
* Add integration tests
Rather than picking the first organisation in an unordered list of
organisations, use the guid defined for the purpose that’s in the
details.

* Raise an error if the referenced organisation isn’t in the links hash

Without an organisation the page can’t render the logo or branding. It
would not be clear which organisation is being referred to.
Use standard partial for translations to match other formats
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-241 Jan 30, 2017 Inactive
@gpeng
gpeng approved these changes Feb 2, 2017
Copy link
Contributor

@gpeng gpeng left a comment

🚢 when 🍏

@gpeng gpeng merged commit 644f538 into master Feb 6, 2017
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@gpeng gpeng deleted the corp-info-page branch Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.