Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render further corporate information at bottom of about pages #250

Merged
merged 3 commits into from Feb 20, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 16, 2017

Goes with:
alphagov/govuk-content-schemas#522

Part of:
https://trello.com/c/8syU3iNh/593-add-corporate-information-block-to-about-pages-corporate-information-pages-2

When corporate information groups are provided (about pages only), append the list of links with headings to the body and render as content without any special rules.

  • Add Corporate information heading
  • Include heading in contents list
  • Links in groups can be GUIDs, internal or external
  • Port translations for strings needing translation from Whitehall
Before After
screen shot 2017-02-16 at 15 39 01 screen shot 2017-02-16 at 15 38 51
fofr added 3 commits Feb 13, 2017
When corporate information groups are provided (about pages only),
append the list of links with headings to the body and render as
content without any special rules.

* Add Corporate information heading
* Include heading in contents list
* Links in groups can be GUIDs, internal or external
Running:
bundle exec rake translation:steal:all[../whitehall,mappings.yml]

Mappings:
organisation.headings.corporate_information: corporate_information_page.corporate_information
worldwide_organisation.corporate_information.publication_scheme_html: corporate_information_page.publication_scheme_html
worldwide_organisation.corporate_information.personal_information_charter_html: corporate_information_page.personal_information_charter_html
worldwide_organisation.corporate_information.welsh_language_scheme_html: corporate_information_page.welsh_language_scheme_html
worldwide_organisation.corporate_information.social_media_use_html: corporate_information_page.social_media_use_html
worldwide_organisation.corporate_information.about_our_services_html: corporate_information_page.about_our_services_html
Based on the links provided in the content item, give further details
about specific content, identified by the document_type.
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-250 Feb 16, 2017 Inactive
@fofr fofr changed the title [Do not merge] Render further corporate information at bottom of about pages Render further corporate information at bottom of about pages Feb 17, 2017
@fofr fofr merged commit d74a05c into master Feb 20, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the corp-about-parts branch Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.