Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid use of `map!` on travel advice #268

Merged
merged 2 commits into from Mar 2, 2017
Merged

Avoid use of `map!` on travel advice #268

merged 2 commits into from Mar 2, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Mar 2, 2017

map! was directly manipulating content_item["details"]["alert_status”]
We should protect content_item from being manipulated

Also adds travel advice to the supported formats table in README.

fofr added 2 commits Mar 2, 2017
map! was directly manipulating `content_item["details"]["alert_status”]`

We should protect content_item from being manipulated
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-268 Mar 2, 2017 Inactive
@cbaines
cbaines approved these changes Mar 2, 2017
@fofr fofr merged commit 5fe1c5b into master Mar 2, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the tweak-travel-advice branch Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.