Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create shared partial for views with left contents and body #276

Merged
merged 2 commits into from Mar 13, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Mar 3, 2017

  • Rename sidebar_with_body to include image
  • Create sidebar_contents_with_body partial
  • Apply to appropriate formats

I recommend reviewing with ?w=1 in the params (ie no whitespace)

fofr added 2 commits Mar 3, 2017
There are other types of “sidebars” too
Move contents logic into shared partial
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-276 Mar 3, 2017 Inactive
@nickcolley nickcolley merged commit b524809 into master Mar 13, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@nickcolley nickcolley deleted the refactor-two-cols branch Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.