Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't render description when there isn't one #332

Merged
merged 1 commit into from Apr 24, 2017
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Apr 24, 2017

Avoid printing an empty paragraph when there is no description.

  • Some specialist documents have no description
  • Description is required, but it can be an empty string

Live example:
https://www.gov.uk/aaib-reports/vans-rv-9a-g-cdmf-2-september-2007

Before

screen shot 2017-04-24 at 16 51 16

After

screen shot 2017-04-24 at 16 51 24

Avoid printing an empty paragraph when there is no description.
* Some specialist documents have no description
* Description is required, but it can be an empty string

Live example:
https://www.gov.uk/aaib-reports/vans-rv-9a-g-cdmf-2-september-2007
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-332 Apr 24, 2017 Inactive
@fofr fofr merged commit db124ff into master Apr 24, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the specialist-docs-desc branch Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.