Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to Guides to match live #346

Merged
merged 2 commits into from May 5, 2017
Merged

Tweaks to Guides to match live #346

merged 2 commits into from May 5, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 5, 2017

Part of https://trello.com/c/g01dZWdI/238-3-render-guides-in-government-frontend-sprint-2

Tweak h2 styles on guides

Before

screen shot 2017-05-05 at 17 16 58

After

screen shot 2017-05-05 at 17 16 44

Live

screen shot 2017-05-05 at 17 19 21

Disable YouTube video expansion

See: alphagov/static#1020

Content on mainstream was not written with expansion enabled, some links to YouTube expand in ways that break content:

eg A link to a video in a list: http://www.gov.uk/attendance-allowance/what-youll-get

* Match rendering on live (frontend, which doesn’t use component)
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-346 May 5, 2017 Inactive
// Distinguish between part titles (27px) and h2s
// within content of part by reducing font-size
//
// Override h2 sizes to match frontend typography

This comment has been minimized.

@nickcolley

nickcolley May 5, 2017
Contributor

can we say 'alphagov/frontend' or something specific for people that are not in the know?

Content on mainstream was not written with expansion enabled, some
links to YouTube expand in ways that break content:

eg A link to a video in a list:
http://www.gov.uk/attendance-allowance/what-youll-get
@fofr fofr force-pushed the guides-typography-tweaks branch from 7d15436 to af9044e May 5, 2017
@nickcolley nickcolley merged commit c5512b7 into master May 5, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@nickcolley nickcolley deleted the guides-typography-tweaks branch May 5, 2017
@nickcolley
Copy link
Contributor

@nickcolley nickcolley commented May 5, 2017

I've put this into our govspeak inconsistency document as a work around...

https://docs.google.com/document/d/1baf6FMuyrnvr0h2Uz1gDPtWAiK2comoO6LhUY6Eugvs/edit?usp=sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.