Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent test failure on guides #381

Merged
merged 1 commit into from Jun 16, 2017
Merged

Fix intermittent test failure on guides #381

merged 1 commit into from Jun 16, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jun 16, 2017

The JSON.parse method omitted content_store_has_item which meant the content store wasn’t always stubbed with the example – sometimes this test would fail, sometimes it would pass, depending on the tests that ran before it.

Avoid risk that this could happen again by updating setup_and_visit_content_item to take URL params.

The `JSON.parse` method omitted `content_store_has_item` which meant
the content store wasn’t always stubbed with the example – sometimes
this test would fail, sometimes it would pass, depending on the tests
that ran before it.

Avoid risk that this could happen again by updating
`setup_and_visit_content_item` to take URL params.
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-381 Jun 16, 2017 Inactive
@nickcolley
Copy link
Contributor

@nickcolley nickcolley commented Jun 16, 2017

🚓 🏃

🐛 🏳️ 💥 🔫 👮‍♀️

🕺 💃 👯‍♂️ 👯

@nickcolley nickcolley merged commit 8f4b429 into master Jun 16, 2017
2 checks passed
@nickcolley nickcolley deleted the fix-flakey-test branch Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants