Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link tracking to HTML Publication contents lists #383

Merged
merged 1 commit into from Jun 22, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jun 21, 2017

  • Track clicks on contents lists
  • We can’t modify HTML Pub contents lists easily, instead write a new
    module to add event listeners on the parent and track links via click
    events within it
  • Use category and action defined on parent container
  • Use the target of the link as the label

When we move the position of contents lists, and if we use the standard ContentsList functionality, then this custom tracking can be removed.

https://trello.com/c/z3YCn9zf/424-implement-ga-tracking-on-html-publication-content-list

@nickcolley @andysellick

* Track clicks on contents lists
* We can’t modify HTML Pub contents lists easily, instead write a new
module to add event listeners on the parent and track links via click
events within it
* Use category and action defined on parent container
* Use the target of the link as the label
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-383 Jun 21, 2017 Inactive
@nickcolley
Copy link
Contributor

@nickcolley nickcolley commented Jun 22, 2017

Tested it using GA Debugger locally, looks good. 👍

@nickcolley nickcolley merged commit 51db069 into master Jun 22, 2017
2 checks passed
@nickcolley nickcolley deleted the html-link-tracking branch Jun 22, 2017
fofr added a commit that referenced this issue Jun 28, 2017
* Contents lists now share a partial that’s already tracked
* Undoes #383 which was intended to be temporary
fofr added a commit that referenced this issue Jul 3, 2017
* Contents lists now share a partial that’s already tracked
* Undoes #383 which was intended to be temporary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants