Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
[Do not merge] Enable sass linting in Jenkins #402
Jenkinsfile docs suggest that sass linting is on by default:
But the logic says:
If the option is omitted, it will default to false.
Before this PR, the Sass linter does not run:
You can see it does run now:
Jenkinsfile docs suggest that sass is on by default: “but aren't linting your SASS yet (you should), you can disable linting” “sassLint Whether or not to run the SASS linter. Default: true” But the logic says: `if (hasAssets() && hasLint() && options.sassLint)` If the option is omitted, it will default to false.
Closing. Puppet change has fixed this: alphagov/govuk-puppet#6131
Reverting the change in a commit, CI runs the sass linter and fails the build as expected: