Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to govuk-lint 3.2.0 #412

Merged
merged 6 commits into from Jul 28, 2017
Merged

Update to govuk-lint 3.2.0 #412

merged 6 commits into from Jul 28, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 27, 2017

  • Remove Sass lint disable comments around BEM classes
  • Autofix linting errors after update

Manual linting fixes:

  • Parenthesise ambiguous blocks
  • Replace > 0, == 0 with readable alternatives
  • Remove duplicate gems (and conditionals) from Gemfile
  • Reduce length of blocks over 25 lines and don't check that cop on test files

Aside, shouldn't govuk-lint be govuk_lint.

https://trello.com/c/G9ImM9lJ/43-1-update-sass-linter-for-bem

@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-412 Jul 27, 2017 Inactive
Copy link
Contributor

@bevanloon bevanloon left a comment

and yes govuk-lint should be govuk_lint.

fofr added 6 commits Jul 27, 2017
These classes are now allowed by our Sass linter:
alphagov/govuk-lint#30
Linting problems that couldn’t be auto fixed
* Parenthesise ambiguous blocks
* Replace > 0, == 0 with readable alternatives
* Remove duplicate gems (and conditionals) from Gemfile
* Fix AmbiguousBlockAssociation linting error
* Fix linter errors by reducing block sizes
* Disable BlockLength linting for tests as many of the lines are needed
for test fixtures

See also:
alphagov/asset-manager@53d4b97
fbb750d9e08ebdb83034b48f9e
alphagov/govuk-lint#80
@fofr fofr force-pushed the bump-linter branch from f30276a to 5885c18 Jul 28, 2017
@fofr fofr merged commit 06bd8fe into master Jul 28, 2017
2 checks passed
2 checks passed
@govuk-ci
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the bump-linter branch Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants