Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow component guide to render on Heroku #416

Merged
merged 1 commit into from Jul 28, 2017
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 28, 2017

We need the component guide to be available in Heroku preview apps to check components in pull requests and to link to versions of the guide.

  • We don't want the component guide to render in production mode
  • Heroku review apps have the production environment set
  • Make a special case for including the guide when a HEROKU env
    variable has been set
  • This allows us to link users to a PR's component guide or master’s

https://government-frontend-pr-416.herokuapp.com/component-guide

@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-416 Jul 28, 2017 Inactive
@fofr fofr force-pushed the heroku-review-components branch from e96a580 to 03fa368 Jul 28, 2017
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-416 Jul 28, 2017 Inactive
@fofr fofr force-pushed the heroku-review-components branch from 03fa368 to 7a22256 Jul 28, 2017
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-416 Jul 28, 2017 Inactive
@fofr fofr force-pushed the heroku-review-components branch from 7a22256 to ce0e5dd Jul 28, 2017
@fofr fofr temporarily deployed to government-frontend-pr-416 Jul 28, 2017 Inactive
@fofr fofr force-pushed the heroku-review-components branch from ce0e5dd to 2395c2f Jul 28, 2017
@fofr fofr temporarily deployed to government-frontend-pr-416 Jul 28, 2017 Inactive
@fofr fofr force-pushed the heroku-review-components branch from 2395c2f to 55eb0d9 Jul 28, 2017
@fofr fofr temporarily deployed to government-frontend-pr-416 Jul 28, 2017 Inactive
@fofr fofr force-pushed the heroku-review-components branch from 55eb0d9 to b9bd48c Jul 28, 2017
@fofr fofr temporarily deployed to government-frontend-pr-416 Jul 28, 2017 Inactive
@fofr fofr force-pushed the heroku-review-components branch from b9bd48c to f62b017 Jul 28, 2017
@fofr fofr temporarily deployed to government-frontend-pr-416 Jul 28, 2017 Inactive
@fofr fofr changed the title [WIP] Allow component guide to render on heroku Allow component guide to render on Heroku Jul 28, 2017
@fofr fofr force-pushed the heroku-review-components branch from f62b017 to 1d61219 Jul 28, 2017
@fofr fofr temporarily deployed to government-frontend-pr-416 Jul 28, 2017 Inactive
@boffbowsh
Copy link
Contributor

@boffbowsh boffbowsh commented Jul 28, 2017

I think this logic will result in different Gemfile.locks depending on how it's run. I think the logic needs to apply to the require: kwarg instead.

* We don't want the component guide to render in production mode
* Heroku review apps have the production environment set
* Make a special case for including the guide when a HEROKU env
  variable has been set
* This allows us to link users to a PR's component guide or master’s
@fofr
Copy link
Contributor Author

@fofr fofr commented Jul 28, 2017

@boffbowsh Updated.

Copy link
Contributor

@boffbowsh boffbowsh left a comment

Just test it deploys ok to Integration first, then this is good to merge.

@fofr fofr merged commit 58b21d3 into master Jul 28, 2017
2 checks passed
@fofr fofr deleted the heroku-review-components branch Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants