Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Marked as do not merge while I double check cross browser. Ready for review.
Notes to reviewers:
Firefox (latest version) doesn't underline some of the elements correctly in the focus state (not a big problem, just being thorough). Not a regression, currently happening on live.
Firefox (live site):
Increasing the line height to 1.4em fixes this.
Also doesn't underline heading list items properly when focussed.
Firefox (latest) does some more odd things on numbered items (only) when focussed. That white gap top and bottom seems to vary in width from item to item. Not a regression, already happening on live.
I think this is being caused by the line height on the spans being slightly different from that on the link - so the outer yellow border lifts away from the background colour on the focussed element. Try slowly decreasing the line height in the inspector to see it in action. If element is inline-block that fixes it, but I don't know what other impact that might have.
* Create contents list helper for styles shared between print and screen (just the table layout styles for lists with formatted numbers) * Disable default print styles * Use our own indent to nest dashed items when printing * Hide the default list item marker when printing for numbered and nested lists * Put print styles on all pages Component guide requires fix before print styles are visible: alphagov/govuk_publishing_components#19