Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't render translations when only one available #431

Merged
merged 1 commit into from Aug 7, 2017
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Aug 7, 2017

Fix issue where “English” is showing by itself on all English detailed guides.

Update translation nav component to only output navigation if there’s
more than one available translation. If there's only one then it's
the current page and the text is redundant.

Fixes:
screen shot 2017-08-07 at 17 16 42

@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-431 Aug 7, 2017 Inactive
@fofr fofr closed this Aug 7, 2017
@fofr
Copy link
Contributor Author

@fofr fofr commented Aug 7, 2017

Re-opening with fix to component instead

@fofr fofr reopened this Aug 7, 2017
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-431 Aug 7, 2017 Inactive
@fofr fofr force-pushed the fix-translations branch from 77570eb to 0cb60a9 Aug 7, 2017
Update translation nav component to only output navigation if there’s
more than one available translation. If there's only one then it's
the current page and the text is redundant.
@gpeng
gpeng approved these changes Aug 7, 2017
@fofr fofr merged commit 4988704 into master Aug 7, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the fix-translations branch Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.