Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress first published date for bulk published specialist documents #435

Merged
merged 1 commit into from Aug 14, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Aug 10, 2017

For certain AAIB reports the publish date is the date the site was scraped rather than the date the report was first published. Ideally the data in the content item would be correct.

https://trello.com/c/FhAbqDhg/
https://govuk.zendesk.com/agent/tickets/2293473

Example:
https://www.gov.uk/aaib-reports/lockheed-l1011-385-1-15-g-bhbr-19-december-1989

Also memoize the result of first_public_at to avoid repetitive sorting of the change history, which could be timely if long.

Before

screen shot 2017-08-10 at 15 08 35

After

screen shot 2017-08-10 at 15 08 47

For certain AAIB reports the publish date is the date the site was
scraped rather than the date the report was first published

These are marked with `bulk_publised: true` in the facet values

https://trello.com/c/FhAbqDhg/
https://govuk.zendesk.com/agent/tickets/2293473
https://govuk.zendesk.com/agent/tickets/1066625

Example:
https://www.gov.uk/aaib-reports/lockheed-l1011-385-1-15-g-bhbr-19-decemb
er-1989

Also memoize the result of first_public_at to avoid repetitive
sorting of the change history, which could be timely if long.
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-435 Aug 10, 2017 Inactive
@andysellick andysellick requested review from binaryberry and alecgibson Aug 14, 2017
@fofr fofr merged commit 751a18b into master Aug 14, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the aaib-dates branch Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.