Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use branch of slimmer to avoid caching erroring pages #445

Merged
merged 1 commit into from Aug 14, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Aug 14, 2017

Slimmer is erroring under a certain set of inputs but catching the error – this leads to an invalid page being cached and served to users.

By letting the error through we will serve a 500, the page will not be cached and users will see the correct content.

See: alphagov/slimmer#202

Slimmer is erroring but catching the error – this leads to an invalid
page being cached and served to users.

By letter the error through we will serve a 500, the page will not be
cached and users will see the correct content.
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-445 Aug 14, 2017 Inactive
@fofr fofr merged commit 63132da into master Aug 14, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the let-slimmer-error-through branch Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.