Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable jasmine tests, stop using slimmer branch #447

Merged
merged 3 commits into from Aug 15, 2017
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Aug 15, 2017

Some clean-up following the recent changes to government-frontend:

fofr added 3 commits Aug 14, 2017
Use patch of jasmine-rails until upstream PR is accepted and versioned:
searls/jasmine-rails#214

Issue documented here:
searls/jasmine-rails#213
XMLHttpRequests are still ok for requests with an `Accept:  text/html`
header.

ie. We can return templates with JS
Stop using a branch and switch to the latest version:
alphagov/slimmer#204

Errors are no longer caught from Slimmer processors.
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-447 Aug 15, 2017 Inactive
@fofr fofr requested a review from h-lame Aug 15, 2017
@fofr fofr merged commit 8448e3b into master Aug 15, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the post-fix-cleanup branch Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.