Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve translation navigation accessibility #453

Merged
merged 8 commits into from Aug 21, 2017
Merged

Improve translation navigation accessibility #453

merged 8 commits into from Aug 21, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Aug 17, 2017

Best reviewed commit by commit.

https://government-frontend-pr-453.herokuapp.com/component-guide/translation-nav

  • Switch to a nav element with an aria-label that can be translated (we don't have translations yet)
  • Include the lang element on the currently active navigation element as a precaution
  • Add links to WCAG for providing lang context and link to example video of pronunciation
  • Include tests for each accessibility change to avoid regressions

Also includes some small cleanups:

  • removes double double underscore from BEM
  • simplifies tests
  • whitespace in locale file
  • tweak to fixture input (Français)

Fixes #443

See guidance on BEM:
http://getbem.com/faq/#what-would-be-a-class-name-for-an-element-inside-
another-element-block__el1__el2-

> block structure should be flattened; you do not need to reflect
nested DOM structure of the block
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-453 Aug 17, 2017 Inactive
@fofr
Copy link
Contributor Author

@fofr fofr commented Aug 17, 2017

CI hasn't run on this PR for some reason. (The green tick is just Snyk)

@fofr fofr force-pushed the aac-tweaks branch from fc65110 to 194cd81 Aug 18, 2017
@fofr fofr temporarily deployed to government-frontend-pr-453 Aug 18, 2017 Inactive
@fofr fofr force-pushed the aac-tweaks branch from 194cd81 to 5b06d1b Aug 18, 2017
@fofr fofr temporarily deployed to government-frontend-pr-453 Aug 18, 2017 Inactive
fofr added 7 commits Aug 17, 2017
Include test to confirm lang attributes are present to codify
accessibility acceptance criteria
* Remove some duplication
* Reduce tests to minimal needed to test functionality
Indicate to search engines that the target pages is in a certain
language – which should help users find the right content through
search engines but isn’t strictly an accessibility acceptance criteria.
While this text can be translated, we don’t yet have any translations
for it.
Use bit.ly URL to avoid auto-expansion of YouTube video
The translation links must:
- [identify the language of the text](https://www.w3.org/TR/UNDERSTANDING-WCAG20/meaning-other-lang-id.html#meaning-other-lang-id-examples-head)

This comment has been minimized.

@nickcolley

nickcolley Aug 18, 2017
Contributor

This is awesome 👍

@nickcolley nickcolley merged commit 3239c79 into master Aug 21, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the aac-tweaks branch Aug 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.