Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add right to left and HTML examples to component guide #465

Merged
merged 5 commits into from Aug 29, 2017
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Aug 29, 2017

Best reviewed with ?w=1 or commit by commit

https://government-frontend-pr-465.herokuapp.com/component-guide

screen shot 2017-08-29 at 13 05 37

fofr added 4 commits Aug 25, 2017
v1 of govuk_publishing_components changed “fixtures” to examples and
specified data in examples using a new block.

alphagov/govuk_publishing_components#37
* Fix bug with right to left contents list
* Add equivalent consultation HTML
* Indicate that banners are used for history notices
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-465 Aug 29, 2017 Inactive
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-465 Aug 29, 2017 Inactive
@@ -21,36 +21,50 @@ accessibility_criteria: |
- be usable with touch
- be usable with [voice commands](https://www.w3.org/WAI/perspectives/voice.html)
- have visible text
fixtures:
examples:
# TODO: We need to add a fixture to show component rendering right-to-left.

This comment has been minimized.

@nickcolley

nickcolley Aug 29, 2017
Contributor

Can we remove this TODO now? :)

Nick Colley
@nickcolley nickcolley merged commit 3a23b68 into master Aug 29, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@nickcolley nickcolley deleted the banner-fix branch Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.