Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bespoke taxonomy sidebar component styles #507

Merged
merged 1 commit into from Oct 31, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Oct 30, 2017

  • Use the add-title-margin class
  • Avoid styling components, this breaks their isolation
  • Makes taxonomy component spacing behave in the same way as related links component

Part of:
https://trello.com/c/FN3ppmn2/60-update-taxonomy-related-links-in-right-column-to-match-the-design-used-by-mainstream-browse-related-links

* Use the `add-title-margin` class
* Avoid styling components, this breaks their isolation
@andysellick
Copy link
Contributor

@andysellick andysellick commented Oct 30, 2017

Can you include a link to the page where this change occurs?

@fofr fofr requested review from vanitabarrett and maxgds Oct 30, 2017
Copy link
Contributor

@andysellick andysellick left a comment

Margin top on mobile seems to be different from live - 50px on live, 15px in this PR. Is that correct?

@fofr
Copy link
Contributor Author

@fofr fofr commented Oct 31, 2017

Should now match other formats like Guides:

https://www.gov.uk/child-benefit?ABTest-EducationNavigation=A

screen shot 2017-10-31 at 09 09 22

@fofr fofr merged commit b7a4fe5 into master Oct 31, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/publishing-e2e-tests Publishing end-to-end tests succeeded on Jenkins
Details
@fofr fofr deleted the cleanup-taxonomy-sidebar-styles branch Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.