Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Create universal layout with no navigation variant #535
Raising this PR in case I need to handover the work at short notice.
Creates a universal layout for:
Tests are applied to these pages based on logic in #526
When the "UniversalNoNav" variant is set:
Still to do:
To test on Heroku:
You say "all content is inline in a left column, with an empty column to the right" but this doesn't apply to headers across the board. Seems like urls with /guidance/ in them constrain the heading to the column, but others, like /adding-fathers-name-birth-certificate have full width headers. Do we need to adjust this? The headers also have different treatment - larger text, more impact.
* Avoid running 10 tests for these document types, one will suffice * When developing locally this number can be increased for confidence
* Increase chances of spotting regressions by ensuring that the `setup_and_visit_random_content_item` test will load pages that sometimes qualify for the AB test
* Add more examples showing how the component renders without publishers * Include details about the component’s purpose and where used, and that it references another component * Fix bug with published dates having a margin that means a date only metadata component looks odd
@maxgds The detailed guides could potentially have translations, which would show in the top right, hence the constraint.
Spoke to @alextea about the different title sizes (based on average length of post) – he was happy to leave as-is for now. I think in the future we might want to base this setting on the length of the title.
The top margin has no effect on most pages – it’s increased by the title that lives above it. Except on the new universal navigation variant where the margin appears too large because the margins aren’t collapsing. The 30px margin is still needed on mobile