Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Render "Topical event about page" format #92
Purposefully alter the topical event about page to look more like other formats. Move the description up, beneath the title, introduce a breadcrumb, add spacing beneath body. * Create a sidebar contents partial * Use heading extraction from content item body to generate contents * Add integration and presenter tests for contents and breadcrumbs
When no contents are shown the grid wrapper is empty. Because it has no height it collapses and the content shifts to the left. To keep the design consistent with what’s currently live, introduce an offset class which is used only when there is no sidebar. Grid helpers like this are best used in the front-end toolkit, but while this is a one-off it makes sense to put it here.
The topical event start and end dates from from the about page’s parent, in its details hash. Start and end dates are optional. * Date range is exclusive of end date (meaning Date and DateTime tests are equivalent), as per Whitehall * Include time based integration and unit tests for breadcrumb output
Thats true, although a unit test would do more to self-document whats going, given it's quite a terse few lines. Refactoring/moving it out to a helper would probably be good enough