Skip to content
This repository has been archived by the owner. It is now read-only.

Remove Google Analytics classic #558

Merged
merged 2 commits into from Jun 1, 2015
Merged

Remove Google Analytics classic #558

merged 2 commits into from Jun 1, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 26, 2015

To be deployed 2 June.

Following on from alphagov/govuk_frontend_toolkit#194

  • Bump govuk_frontend_toolkit to pull in latest analytics
  • Remove references to classic tracker
  • Remove classic specific arguments (eg custom variable name and scope)
  • Update references of GOVUK.Tracker to GOVUK.Analytics
fofr added 2 commits May 14, 2015
Pull in latest analytics changes which remove Google Analytics classic.

(Run `git pull origin master` within toolkit directory)
@alicebartlett
Copy link
Contributor

@alicebartlett alicebartlett commented May 28, 2015

Yep 👍 LGTM

@jabley

This comment has been minimized.

Copy link
Contributor

@jabley jabley commented on service-manual/assets/javascript/analytics-init.js in 8f51c5a May 28, 2015

This looks slightly odd to my untrained eye. You've intentionally changed the universalId, as well as dropping the classicId?

This comment has been minimized.

Copy link
Contributor Author

@fofr fofr replied May 28, 2015

It is odd. Here's what's happening:

  • The profile UA-26179049-1, currently classic, will continue collecting data but will collect it through Universal.
  • The temporary Universal profile UA-26179049-7, setup to test Universal, will stop collecting data

By keeping UA-26179049-1 we have a profile with all historic data in it.

bradwright added a commit that referenced this pull request Jun 1, 2015
Remove Google Analytics classic
@bradwright bradwright merged commit cd072b2 into master Jun 1, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bradwright bradwright deleted the remove-classic-analytics branch Jun 1, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.