Permalink
Commits on May 4, 2017
  1. Merge pull request #108 from alphagov/jenkins-2

    Build on Jenkins 2
    kevindew committed on GitHub May 4, 2017
  2. Remove old CI files

    Now this builds on Jenkins 2 we don't need to build on travis or have
    the Jenkins file for the old CI.
    kevindew committed May 4, 2017
  3. Merge pull request #106 from alphagov/bump-version

    Bump to 5.0.3
    kevindew committed on GitHub May 4, 2017
Commits on May 3, 2017
  1. Merge pull request #107 from thisislawatts/patch-2

    Adds line breaks to .contact example
    kevindew committed on GitHub May 3, 2017
  2. Update README.md

    thisislawatts committed on GitHub May 3, 2017
  3. Bump to 5.0.3

    kevindew committed May 3, 2017
  4. Merge pull request #105 from alphagov/fix-regex-bug

    Convert regex matches to equals
    kevindew committed on GitHub May 3, 2017
  5. Merge pull request #104 from thisislawatts/patch-1

    Wrap all example markup with HTML syntax highlighting
    kevindew committed on GitHub May 3, 2017
  6. Convert regex matches to equals

    This changes how we check whether a content_id matches for
    link/contacts/attachments. As the content_id is user input it should not be
    treated as a regex, so the equality operator is used instead. This
    shouldn't break any existing usages as nothing should have been reliant
    on regexs.
    
    This is to fix an error that was occurring of: "premature end of
    char-class: /1-1992 G-BJRT[2/"
    kevindew committed May 3, 2017
Commits on Apr 19, 2017
Commits on Oct 11, 2016
  1. Merge pull request #100 from alphagov/version_5_0_2

    Bump to version 5.0.2.
    danielroseman committed on GitHub Oct 11, 2016
  2. Bump to version 5.0.2.

    danielroseman committed Oct 11, 2016
  3. Merge pull request #99 from alphagov/rails5-compatibility

    Loosen ActionView dep for Rails 5 compatibility.
    boffbowsh committed on GitHub Oct 11, 2016
  4. Loosen ActionView dep for Rails 5 compatibility.

    This allows the gem to be included in apps that use Rails 5.
    
    We test against different versions of Ruby, but ActionView 5 does not
    build in versions before 2.3. Because the `>=` gem specifier always
    finds the latest version, we need to use a different specifier for
    earlier Ruby versions, so this configures Travis to use a different
    Gemfile for each one.
    danielroseman committed Sep 24, 2016
Commits on Oct 4, 2016
  1. Merge pull request #97 from alphagov/bump-to-5.0.1

    Bump to version 5.0.1
    carlosmartinez committed on GitHub Oct 4, 2016
  2. Bump to version 5.0.1

    kevindew committed Oct 4, 2016
Commits on Oct 3, 2016
  1. Merge pull request #95 from alphagov/dup-options

    Duplicate options passed into Govspeak
    carlosmartinez committed on GitHub Oct 3, 2016
  2. Merge pull request #96 from alphagov/embed-link-with-markdown

    Use markdown to embed links
    carlosmartinez committed on GitHub Oct 3, 2016
  3. Merge pull request #94 from alphagov/5.0-documentation

    Update README for 5.0
    carlosmartinez committed on GitHub Oct 3, 2016
  4. Update README for 5.0

    This brings the content in the README up to date.
    kevindew committed Oct 3, 2016
  5. Duplicate options passed into Govspeak

    Rather than mutating as we alter it in the initialize method
    kevindew committed Oct 3, 2016
  6. Use markdown to embed links

    Allows us to benefit from our other link processing aspects, such as
    marking links as external
    kevindew committed Oct 3, 2016
  7. Merge pull request #93 from alphagov/modularise-presenters

    Move presenters into govspeak namespace
    dougdroper committed on GitHub Oct 3, 2016
  8. Move presenters into govspeak namespace

    This resolves conflicts we have where codebases use classes such as
    AttachmentPresenter.
    
    Also fixes a few coding standards issues.
    kevindew committed Oct 3, 2016
Commits on Sep 30, 2016
  1. Merge pull request #92 from alphagov/version-bump

    Bump to version 5.0.0
    carlosmartinez committed on GitHub Sep 30, 2016
  2. Bump to version 5.0.0

    kevindew committed Sep 30, 2016
  3. Merge pull request #91 from alphagov/gracefully-failing-elements

    Render bad usage of markdown as empty strings
    danielroseman committed on GitHub Sep 30, 2016
  4. Render bad usage of markdown as empty strings

    Prior to this change `[embed:attachments:filename.jpg]` would be
    rendered on the frontend amongst the content. This change means that it
    would be rendered as an empty string.
    
    Although it is debatable which route is better, having this render empty
    strings does allow us to resolve some issues with missing attachments on
    Specialist Publisher.
    kevindew committed Sep 30, 2016
  5. Merge pull request #90 from alphagov/image-attachments

    Image attachments
    danielroseman committed on GitHub Sep 30, 2016
Commits on Sep 29, 2016
  1. Don't die when an attachment is missing a title

    kevindew committed Sep 29, 2016
  2. Allow attachment images to be used within block elements

    Image attachments can be embedded inside HTML block level elements to
    different degrees of validity eg inside a <p> that's invalid whereas
    inside a <td> it's valid.
    
    However the way kramdown handles these scenarios is not desirable in
    either instance. It will convert the block level HTML elements into
    their HTML entity equivalent - thus an end user would see <div
    class="img"> on their screen.
    
    The way I've fixed this isn't pretty, we try output the image in a
    single line - which resolves some issues - and then we try convert back
    elements we expect to have been converted back to HTML.
    kevindew committed Sep 29, 2016
Commits on Sep 28, 2016
  1. Add image attachment support with embed syntax

    Attachments can be embedded using `[embed:attachment:image:<content-id>]`. This
    allows us to support specialist publisher inline image attachments and
    hopefully it can evolve to become the format other apps use for inline
    attachments.
    kevindew committed Sep 28, 2016