Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on Jenkins 2 #108

Merged
merged 2 commits into from May 4, 2017
Merged

Build on Jenkins 2 #108

merged 2 commits into from May 4, 2017

Conversation

kevindew
Copy link
Member

@kevindew kevindew commented May 4, 2017

We were no longer having builds run by our CI which meant that releases were no longer automatic.

Since our CI will run on every commit I've moved the tests that travis was doing to be within our build pipeline, so that we can't accidentally ship a gem where the build fails.

Copy link
Contributor

@thomasleese thomasleese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One minor comment.

Jenkinsfile Outdated
allowMissing: false,
alwaysLinkToLastBuild: false,
keepAll: true,
reportDir: 'coverage/rcov',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed single and double quotes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! it was a total mess on that front (insert some sort of shame emoji)

Now this builds on Jenkins 2 we don't need to build on travis or have
the Jenkins file for the old CI.
@kevindew kevindew merged commit 0d097e1 into master May 4, 2017
@kevindew kevindew deleted the jenkins-2 branch May 4, 2017 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants