Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix govspeak failures when using IALs on links #75
Inline attribute lists (IALs) were added to links in Kramdown 1.6.0:
This changed the
I am not sure why existing markdown in content was triggering this IAL feature.
Inline attribute lists (IALs) were added to links in Kramdown 1.6.0: gettalong/kramdown@6279785 5aae9cc9e2934 http://kramdown.gettalong.org/syntax.html#block-ials https://github.com/gettalong/kramdown/blob/60795eb95f1588d41e105407add2d 3ba6a7fc101/doc/news/release_1_6_0.page This changed the `add_link` signature. We monkey patch this in `kramdown_with_automatic_external_links` to add “rel=external” but we didn’t update that signature when we bumped Kramdown. There were no tests using the IAL feature so the error was not spotted. Live markdown examples do however trigger this feature, which leads to the error: `ArgumentError: wrong number of arguments (5 for 3..4)` * Include simple IAL external link test * Include kramdown’s own IAL link tests
The signature of this method has been changed upstream: https://github.com/gettalong/kramdown/blob/60795eb95f1588d41e105407add2d 3ba6a7fc101/lib/kramdown/parser/kramdown/link.rb#L38 As part of: gettalong/kramdown@6279785 5aae9cc9e2934 https://github.com/gettalong/kramdown/blob/60795eb95f1588d41e105407add2d 3ba6a7fc101/doc/news/release_1_6_0.page Fixes previously committed failing tests.