Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant completions #1213

Merged
merged 1 commit into from Jan 9, 2020
Merged

Remove redundant completions #1213

merged 1 commit into from Jan 9, 2020

Conversation

@chao-xian
Copy link
Member

chao-xian commented Jan 8, 2020

The auto-completions for govukcli aws is no longer needed as aws
features were removed.

Copy link
Member

issyl0 left a comment

Thanks. Line 29 (in GLOBAL_COMMANDS) can also go.

The auto-completions for govukcli aws is no longer needed as aws
features were removed.
@chao-xian chao-xian force-pushed the remove-aws-completions branch from 983dc2e to 3c47c82 Jan 8, 2020
@chao-xian

This comment has been minimized.

Copy link
Member Author

chao-xian commented Jan 8, 2020

@issyl0 thanks - fixed

@issyl0
issyl0 approved these changes Jan 9, 2020
Copy link
Member

issyl0 left a comment

Thanks for this Kelvin!

@issyl0 issyl0 merged commit 95376d5 into master Jan 9, 2020
2 checks passed
2 checks passed
concourse-ci/status Concourse CI build success
Details
continuous-integration/jenkins/branch This commit looks good
Details
@issyl0 issyl0 deleted the remove-aws-completions branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.