Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for terraform-docs 0.8.2 #1247

Merged
merged 3 commits into from Feb 5, 2020
Merged

Update docs for terraform-docs 0.8.2 #1247

merged 3 commits into from Feb 5, 2020

Conversation

@kevindew
Copy link
Member

kevindew commented Feb 5, 2020

In #1245 I'm seeing a failed build due to docs not matching expected output. This failure seems to be because terraform-docs has had a new release (0.8.2) rather the PR contents so this is a separate commit to fix the issues we have with the new version.

/cc @sarahseewhy @sengi

kevindew added 2 commits Feb 5, 2020
In the newer version of terraform-docs (0.8.2) this extra space is included
breaking the markdown header.
In #1245 I'm seeing a failed
build due to docs not matching expected output. This failure seems to be
because terraform-docs has had a new release (0.8.2) rather the PR contents
so this is a separate commit to fix the issues we have with the new
version.

This has seemed to have broken the situations where we embed code with
three backticks.
@kevindew kevindew force-pushed the update-docs branch from 1937f4d to 3afed4c Feb 5, 2020
These were broken by terraform-docs changing from 0.8.1 to 0.8.2
@kevindew kevindew force-pushed the update-docs branch from 93f3f1d to ecaee6d Feb 5, 2020
@kevindew kevindew changed the title [WIP] Update docs for terraform-docs 0.8.2 Update docs for terraform-docs 0.8.2 Feb 5, 2020
@issyl0
issyl0 approved these changes Feb 5, 2020
Copy link
Member

issyl0 left a comment

😭Thank you! ⭐️

@kevindew kevindew merged commit 2c13502 into master Feb 5, 2020
2 checks passed
2 checks passed
concourse-ci/status Concourse CI build success
Details
continuous-integration/jenkins/branch This commit looks good
Details
@kevindew kevindew deleted the update-docs branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.