Skip to content
This repository has been archived by the owner. It is now read-only.

Bump slimmer to 8.1.0 #13

Merged
merged 2 commits into from Mar 25, 2015
Merged

Bump slimmer to 8.1.0 #13

merged 2 commits into from Mar 25, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Mar 25, 2015

Pick up analytics changes. Use HTML meta tags rather than JS variables for custom dimensions.
https://github.com/alphagov/slimmer/blob/master/CHANGELOG.md

Pick up analytics changes. Use HTML meta tags rather than JS variables
for custom dimensions.
@benilovj
Copy link
Contributor

@benilovj benilovj commented Mar 25, 2015

Why is it necessary to hide the problem toggle and form? If the point is to not have the form appear at all, it's better to set the Slimmer::Headers::REPORT_A_PROBLEM_FORM header to false (see here).

The form doesn't work when an app is hosted elsewhere.
It also isn't relevant here.
@fofr fofr force-pushed the bump-slimmer branch from 86aab81 to e325b09 Mar 25, 2015
@fofr
Copy link
Contributor Author

@fofr fofr commented Mar 25, 2015

@benilovj Good point, I've switched to using the header rather than CSS.

The guide currently lives here: http://govuk-component-guide.herokuapp.com/, the form wouldn't work.

benilovj added a commit that referenced this pull request Mar 25, 2015
Bump slimmer to 8.1.0
@benilovj benilovj merged commit ceab085 into master Mar 25, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@benilovj benilovj deleted the bump-slimmer branch Mar 25, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.