Skip to content
This repository has been archived by the owner. It is now read-only.

Upgrade to Rails 5 #45

Merged
merged 3 commits into from Aug 7, 2017
Merged

Upgrade to Rails 5 #45

merged 3 commits into from Aug 7, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 27, 2017

Before switching the component guide to use the govuk_publishing_components gem we need to update it to Rails 5.

fofr added 3 commits Jul 27, 2017
* Named params
* Deprecated config flags
* before_filter is now before_action
* Bumps nokogiri to fix security issues
@fofr fofr force-pushed the rails-5 branch 2 times, most recently from 784e4da to 3b5c760 Jul 27, 2017
@fofr
Copy link
Contributor Author

@fofr fofr commented Jul 27, 2017

I don't know how we've dealt with these Snyk warnings on other projects that are using the same gem versions as this.

@@ -3,9 +3,9 @@ source 'https://rubygems.org'
ruby File.read('.ruby-version').strip

# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
gem 'rails', '4.2.4'
gem 'rails', '5.0.4'

This comment has been minimized.

@bevanloon

bevanloon Jul 28, 2017

Notice that some of our other apps are using 5.1 - e.g. https://github.com/alphagov/publishing-api/blob/master/Gemfile#L4
and I notice 5.1.2 is out (http://weblog.rubyonrails.org/2017/6/26/Rails-5-1-2-has-been-released/)
Is this a conscious decision to use 5.0.4?

This comment has been minimized.

@fofr

fofr Aug 7, 2017
Author Contributor

Going to look at 5.1 as a separate PR.

@fofr fofr merged commit 21f6c1d into master Aug 7, 2017
2 of 3 checks passed
2 of 3 checks passed
security/snyk 2 new vulnerable dependency paths
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@fofr fofr deleted the rails-5 branch Aug 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.